add AutoWorld.generate_early, optimize Location

worlds/AutoWorld.py

@@ -69,6 +69,9 @@ class World(metaclass=AutoWorldRegister):
         self.player = player
 
     # overwritable methods that get called by Main.py, sorted by execution order
+    def generate_early(self):
+        pass
+
     def create_regions(self):
         pass
 

worlds/factorio/__init__.py

@@ -44,11 +44,10 @@ class Factorio(World):
 
     def create_regions(self):
         player = self.player
-        menu = Region("Menu", None, "Menu", player)
+        menu = Region("Menu", None, "Menu", player, self.world)
         crash = Entrance(player, "Crash Land", menu)
         menu.exits.append(crash)
-        nauvis = Region("Nauvis", None, "Nauvis", player)
-        nauvis.world = menu.world = self.world
+        nauvis = Region("Nauvis", None, "Nauvis", player, self.world)
 
         for tech_name, tech_id in base_tech_table.items():
             tech = Location(player, tech_name, tech_id, nauvis)

worlds/minecraft/Regions.py

@@ -14,7 +14,7 @@ def link_minecraft_structures(world, player):
         assert len(exits) == len(structs)
     except AssertionError as e: # this should never happen
         raise Exception(f"Could not obtain equal numbers of Minecraft exits and structures for player {player} ({world.player_names[player]})")
-    num_regions = len(exits)
+
     pairs = {}
 
     def set_pair(exit, struct):