morgan/Grinch-AP
1
0
Fork 0
mirror of https://github.com/MarioSpore/Grinch-AP.git synced 2025-10-21 20:21:32 -06:00
Code Issues Packages Projects Releases Wiki Activity

HK: slight optimization

Browse Source 
items are marked as advancement if they have an additional effect, so instead of a lookup we can just refer to a bool that's already local as a quick pre-check
This commit is contained in:
Fabian Dill
2022-04-08 21:30:38 +02:00
committed by Fabian Dill
parent 7a6aef03e7
commit 15dcdca6fc
1 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
worlds/hk/__init__.py
View File

@@ -257,19 +257,20 @@ class HKWorld(World):
def collect(self, state, item: HKItem) -> bool: def collect(self, state, item: HKItem) -> bool:
change = super(HKWorld, self).collect(state, item) change = super(HKWorld, self).collect(state, item)
if change:
for effect_name, effect_value in item_effects.get(item.name, {}).items(): for effect_name, effect_value in item_effects.get(item.name, {}).items():
state.prog_items[effect_name, item.player] += effect_value state.prog_items[effect_name, item.player] += effect_value
return change return change
def remove(self, state, item: HKItem) -> bool: def remove(self, state, item: HKItem) -> bool:
change = super(HKWorld, self).remove(state, item) change = super(HKWorld, self).remove(state, item)
for effect_name, effect_value in item_effects.get(item.name, {}).items(): if change:
if state.prog_items[effect_name, item.player] == effect_value: for effect_name, effect_value in item_effects.get(item.name, {}).items():
del state.prog_items[effect_name, item.player] if state.prog_items[effect_name, item.player] == effect_value:
state.prog_items[effect_name, item.player] -= effect_value del state.prog_items[effect_name, item.player]
state.prog_items[effect_name, item.player] -= effect_value
return change return change