morgan/Grinch-AP
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Sc2: [performance] change default options (#5424)

Browse Source 
* sc2: Changing default campaign options to something more performative and desirable for new players

* sc2: Fixing broken test that was missed in roundup

* SC2: Update tests for new defaults

* SC2: Fix incomplete test

* sc2: Updating description for enabled campaigns to mention which are free to play

* sc2: PR comments; Updating additional unit tests that were affected by a default change

* sc2: Adding a comment to the Enabled Campaigns option to list all the valid campaign names

* sc2: Adding quotes wrapping sample values in enabled_campaigns comment to aid copy-pasting

---------

Co-authored-by: Salzkorn <salzkitty@gmail.com>
This commit is contained in:
Phaneros
2025-09-30 09:36:41 -07:00
committed by GitHub
parent 897d5ab089
commit 49f2d30587
7 changed files with 98 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
worlds/sc2/test/test_usecases.py
View File

@@ -272,7 +272,7 @@ class TestSupportedUseCases(Sc2SetupTestBase):
def test_race_swap_pick_one_has_correct_length_and_includes_swaps(self) -> None:
world_options = {
'selected_races': options.SelectRaces.valid_keys,
'selected_races': options.SelectedRaces.valid_keys,
'enable_race_swap': options.EnableRaceSwapVariants.option_pick_one,
'enabled_campaigns': {
SC2Campaign.WOL.campaign_name,
@@ -343,6 +343,7 @@ class TestSupportedUseCases(Sc2SetupTestBase):
def test_kerrigan_max_active_abilities(self):
target_number: int = 8
world_options = {
**self.ALL_CAMPAIGNS,
'mission_order': options.MissionOrder.option_grid,
'maximum_campaign_size': options.MaximumCampaignSize.range_end,
'selected_races': {
@@ -361,6 +362,7 @@ class TestSupportedUseCases(Sc2SetupTestBase):
def test_kerrigan_max_passive_abilities(self):
target_number: int = 3
world_options = {
**self.ALL_CAMPAIGNS,
'mission_order': options.MissionOrder.option_grid,
'maximum_campaign_size': options.MaximumCampaignSize.range_end,
'selected_races': {
@@ -379,6 +381,7 @@ class TestSupportedUseCases(Sc2SetupTestBase):
def test_spear_of_adun_max_active_abilities(self):
target_number: int = 8
world_options = {
**self.ALL_CAMPAIGNS,
'mission_order': options.MissionOrder.option_grid,
'maximum_campaign_size': options.MaximumCampaignSize.range_end,
'selected_races': {
@@ -398,6 +401,7 @@ class TestSupportedUseCases(Sc2SetupTestBase):
def test_spear_of_adun_max_autocasts(self):
target_number: int = 2
world_options = {
**self.ALL_CAMPAIGNS,
'mission_order': options.MissionOrder.option_grid,
'maximum_campaign_size': options.MaximumCampaignSize.range_end,
'selected_races': {
@@ -417,6 +421,7 @@ class TestSupportedUseCases(Sc2SetupTestBase):
def test_nova_max_weapons(self):
target_number: int = 3
world_options = {
**self.ALL_CAMPAIGNS,
'mission_order': options.MissionOrder.option_grid,
'maximum_campaign_size': options.MaximumCampaignSize.range_end,
'selected_races': {
@@ -436,6 +441,7 @@ class TestSupportedUseCases(Sc2SetupTestBase):
def test_nova_max_gadgets(self):
target_number: int = 3
world_options = {
**self.ALL_CAMPAIGNS,
'mission_order': options.MissionOrder.option_grid,
'maximum_campaign_size': options.MaximumCampaignSize.range_end,
'selected_races': {
@@ -453,6 +459,7 @@ class TestSupportedUseCases(Sc2SetupTestBase):
def test_mercs_only(self) -> None:
world_options = {
**self.ALL_CAMPAIGNS,
'selected_races': [
SC2Race.TERRAN.get_title(),
SC2Race.ZERG.get_title(),