From 4d1736666269b9be61890f8cd0d3fe4b9633d38d Mon Sep 17 00:00:00 2001 From: Doug Hoskisson Date: Mon, 28 Jul 2025 06:41:43 -0700 Subject: [PATCH] Core: fix dangerous mutable default in Fill (#5247) discussed here https://discord.com/channels/731205301247803413/731214280439103580/1327712564213448775 --- Fill.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/Fill.py b/Fill.py index 29a9a530..1cc1278f 100644 --- a/Fill.py +++ b/Fill.py @@ -358,7 +358,12 @@ def fast_fill(multiworld: MultiWorld, return item_pool[placing:], fill_locations[placing:] -def accessibility_corrections(multiworld: MultiWorld, state: CollectionState, locations, pool=[]): +def accessibility_corrections(multiworld: MultiWorld, + state: CollectionState, + locations: list[Location], + pool: list[Item] | None = None) -> None: + if pool is None: + pool = [] maximum_exploration_state = sweep_from_pool(state, pool) minimal_players = {player for player in multiworld.player_ids if multiworld.worlds[player].options.accessibility == "minimal"}