Stardew Valley: 5.x.x - The Allsanity Update (#2764)

Major Content update for Stardew Valley, including the following features

- Major performance improvements all across the Stardew Valley apworld, including a significant reduction in the test time
- Randomized Farm Type
- Bundles rework (Remixed Bundles and Missing Bundle!)
- New Settings:
  * Shipsanity - Shipping individual items
  * Monstersanity - Slaying monsters
  * Cooksanity - Cooking individual recipes
  * Chefsanity - Learning individual recipes
  * Craftsanity - Crafting individual items
- New Goals:
  * Protector of the Valley - Complete every monster slayer goal
  * Full Shipment - Ship every item
  * Craftmaster - Craft every item
  * Gourmet Chef - Cook every recipe
  * Legend - Earn 10 000 000g
  * Mystery of the Stardrops - Find every stardrop (Maguffin Hunt)
  * Allsanity - Complete every check in your slot
- Building Shuffle: Cheaper options
- Tool Shuffle: Cheaper options
- Money rework
- New traps
- New isolated checks and items, including the farm cave, the movie theater, etc
- Mod Support: SVE [Albrekka]
- Mod Support: Distant Lands [Albrekka]
- Mod Support: Hat Mouse Lacey [Albrekka]
- Mod Support: Boarding House [Albrekka]

Co-authored-by: Witchybun <elnendil@gmail.com>
Co-authored-by: Witchybun <96719127+Witchybun@users.noreply.github.com>
Co-authored-by: Jouramie <jouramie@hotmail.com>
Co-authored-by: Alchav <59858495+Alchav@users.noreply.github.com>

worlds/stardew_valley/test/stability/StabilityOutputScript.py

@@ -0,0 +1,32 @@
+import argparse
+import json
+
+from ...test import setup_solo_multiworld, allsanity_options_with_mods
+
+if __name__ == "__main__":
+    parser = argparse.ArgumentParser()
+    parser.add_argument('--seed', help='Define seed number to generate.', type=int, required=True)
+
+    args = parser.parse_args()
+    seed = args.seed
+
+    multi_world = setup_solo_multiworld(
+        allsanity_options_with_mods(),
+        seed=seed
+    )
+
+    output = {
+        "bundles": {
+            bundle_room.name: {
+                bundle.name: str(bundle.items)
+                for bundle in bundle_room.bundles
+            }
+            for bundle_room in multi_world.worlds[1].modified_bundles
+        },
+        "items": [item.name for item in multi_world.get_items()],
+        "location_rules": {location.name: repr(location.access_rule) for location in multi_world.get_locations(1)}
+    }
+
+    print(json.dumps(output))
+else:
+    raise RuntimeError("Do not import this file, execute it in different python session so the PYTHONHASHSEED is different..")

worlds/stardew_valley/test/stability/TestStability.py

@@ -0,0 +1,52 @@
+import json
+import re
+import subprocess
+import sys
+
+from BaseClasses import get_seed
+from .. import SVTestCase
+
+# <function Location.<lambda> at 0x102ca98a0>
+lambda_regex = re.compile(r"^<function Location\.<lambda> at (.*)>$")
+# Python 3.10.2\r\n
+python_version_regex = re.compile(r"^Python (\d+)\.(\d+)\.(\d+)\s*$")
+
+
+class TestGenerationIsStable(SVTestCase):
+    """Let it be known that I hate this tests, and if someone has a better idea than starting subprocesses, please fix this.
+    """
+
+    def test_all_locations_and_items_are_the_same_between_two_generations(self):
+        if self.skip_long_tests:
+            return
+
+        # seed = get_seed(33778671150797368040) # troubleshooting seed
+        seed = get_seed()
+
+        output_a = subprocess.check_output([sys.executable, '-m', 'worlds.stardew_valley.test.stability.StabilityOutputScript', '--seed', str(seed)])
+        output_b = subprocess.check_output([sys.executable, '-m', 'worlds.stardew_valley.test.stability.StabilityOutputScript', '--seed', str(seed)])
+
+        result_a = json.loads(output_a)
+        result_b = json.loads(output_b)
+
+        for i, ((room_a, bundles_a), (room_b, bundles_b)) in enumerate(zip(result_a["bundles"].items(), result_b["bundles"].items())):
+            self.assertEqual(room_a, room_b, f"Bundle rooms at index {i} is different between both executions. Seed={seed}")
+            for j, ((bundle_a, items_a), (bundle_b, items_b)) in enumerate(zip(bundles_a.items(), bundles_b.items())):
+                self.assertEqual(bundle_a, bundle_b, f"Bundle in room {room_a} at index {j} is different between both executions. Seed={seed}")
+                self.assertEqual(items_a, items_b, f"Items in bundle {bundle_a} are different between both executions. Seed={seed}")
+
+        for i, (item_a, item_b) in enumerate(zip(result_a["items"], result_b["items"])):
+            self.assertEqual(item_a, item_b, f"Item at index {i} is different between both executions. Seed={seed}")
+
+        for i, ((location_a, rule_a), (location_b, rule_b)) in enumerate(zip(result_a["location_rules"].items(), result_b["location_rules"].items())):
+            self.assertEqual(location_a, location_b, f"Location at index {i} is different between both executions. Seed={seed}")
+
+            match = lambda_regex.match(rule_a)
+            if match:
+                self.assertTrue(bool(lambda_regex.match(rule_b)),
+                                f"Location rule of {location_a} at index {i} is different between both executions. Seed={seed}")
+                continue
+
+            # We check that the actual rule has the same order to make sure it is evaluated in the same order,
+            #  so performance tests are repeatable as much as possible.
+            self.assertEqual(rule_a, rule_b, f"Location rule of {location_a} at index {i} is different between both executions. Seed={seed}")