Stardew Valley: 4.x.x - The Ginger Update (#1931)

## What is this fixing or adding?
Major content update for Stardew Valley

## How was this tested?
One large-scale public Beta on the archipelago server, plus several smaller private asyncs and test runs

You can go to https://github.com/agilbert1412/StardewArchipelago/releases to grab the mod (latest 4.x.x version), the supported mods and the apworld, to test this PR

## New Features:
- Festival Checks [Easy mode or Hard Mode]
- Special Orders [Both Board and Qi]
- Willy's Boat
- Ginger Island Parrots
- TV Channels
- Trap Items [Available in various difficulty levels]
- Entrance Randomizer: Buildings and Chaos
- New Fishsanity options: Exclude Legendaries, Exclude Hard fish, Only easy fish
- Resource Pack overhaul [Resource packs are now more enjoyable and varied]
- Goal: Greatest Walnut Hunter [Find every single Golden Walnut]
- Goal: Perfection [Achieve Perfection]
- Option: Profit Margin [Multiplier over all earnings]
- Option: Friendsanity Heart Size [Reduce clutter from friendsanity hearts]
- Option: Exclude Ginger Island - will exclude many locations and items to generate a playthrough that does not go to the island
- Mod Support [Curated list of mods]

## New Contributors:
@Witchybun for the mod support

---------

Co-authored-by: Witchybun <embenham05@gmail.com>
Co-authored-by: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com>
Co-authored-by: Fabian Dill <Berserker66@users.noreply.github.com>

worlds/stardew_valley/scripts/update_data.py

@@ -11,7 +11,7 @@ from pathlib import Path
 from typing import List
 
 from worlds.stardew_valley import LocationData
-from worlds.stardew_valley.items import load_item_csv, Group, ItemData, load_resource_pack_csv, friendship_pack
+from worlds.stardew_valley.items import load_item_csv, Group, ItemData
 from worlds.stardew_valley.locations import load_location_csv
 
 RESOURCE_PACK_CODE_OFFSET = 5000
@@ -53,22 +53,23 @@ if __name__ == "__main__":
                                        for item in loaded_items
                                        if Group.RESOURCE_PACK not in item.groups
                                        and item.code_without_offset is not None) + 1)
+
+    resource_pack_counter = itertools.count(max(item.code_without_offset
+                                       for item in loaded_items
+                                       if Group.RESOURCE_PACK in item.groups
+                                       and item.code_without_offset is not None) + 1)
     items_to_write = []
     for item in loaded_items:
-        if item.has_any_group(Group.RESOURCE_PACK, Group.FRIENDSHIP_PACK):
-            continue
-
         if item.code_without_offset is None:
-            items_to_write.append(ItemData(next(item_counter), item.name, item.classification, item.groups))
+            if Group.RESOURCE_PACK in item.groups:
+                new_code = next(resource_pack_counter)
+            else:
+                new_code = next(item_counter)
+            items_to_write.append(ItemData(new_code, item.name, item.classification, item.groups))
             continue
 
         items_to_write.append(item)
 
-    all_resource_packs = load_resource_pack_csv() + [friendship_pack]
-    resource_pack_counter = itertools.count(RESOURCE_PACK_CODE_OFFSET)
-    items_to_write.extend(
-        item for resource_pack in all_resource_packs for item in resource_pack.as_item_data(resource_pack_counter))
-
     write_item_csv(items_to_write)
 
     loaded_locations = load_location_csv()