Witness: Bugfixes in response to beta tests (#1473)

* Make all Keep Pressure Plates logically required for the Laser Panel

* Added more Tutorial checks

* Added the remaining two Shipwreck Boat EPs to the exclude list for normal

* Improved itempool filling system, added warning if usefuls had to be eaten

* Moved creation of said warning string to utils

* Fixed logic bug causing broken seeds on Mountain Floor 2

* Hints system change

* Expert Logic Fix

* Fixed typo

* Better wording

* Added missing games to junk hints

* Made sure Entrance names are unique

* Fixed missing Obelisk Side

* Disable Non Randomized + EP Shuffle fix

* Fixed disable_non_randomized precompleted EPs being 'disabled' instead of 'precompleted'

* Fixed if/elif error

* Tutorial Gate Open local symbol item becomes local_early_item in expert instead

* Bump required client version. There is a beta client that sends 0.3.9.

* Removed print statement, oops

* Fixed itempool manipulation in pre_fill

* Replaced string concats with fstrings

* Improved make_warning_string function signature

Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>

* Improved performance on removing multiple items from multiworld itempool

* Comment

* Fixed errors with the code

* Made removal from itempool not fail unit test for multiple references

* Moved all item creation to create_items, got rid of itempool modifying system

* Colored Squares is no longer a good item, that's outdated

* Removed double if

* React to from_pool: false by removing a junk item

* Fixed warning if only Fnc Brain was removed

* Make use of string truthiness instead

* Made reading of plandoed items safer

---------

Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>

worlds/witness/items.py

@@ -205,13 +205,10 @@ class WitnessPlayerItems:
                 ]
 
             if is_option_enabled(multiworld, player, "shuffle_discarded_panels"):
-                if is_option_enabled(multiworld, player, "shuffle_discarded_panels"):
-                    if get_option_value(multiworld, player, "puzzle_randomization") == 1:
-                        self.GOOD_ITEMS.append("Arrows")
-                    else:
-                        self.GOOD_ITEMS.append("Triangles")
-            if not is_option_enabled(multiworld, player, "disable_non_randomized_puzzles"):
-                self.GOOD_ITEMS.append("Colored Squares")
+                if get_option_value(multiworld, player, "puzzle_randomization") == 1:
+                    self.GOOD_ITEMS.append("Arrows")
+                else:
+                    self.GOOD_ITEMS.append("Triangles")
 
             self.GOOD_ITEMS = [
                 StaticWitnessLogic.ITEMS_TO_PROGRESSIVE.get(item, item) for item in self.GOOD_ITEMS