Rogue Legacy: More refactoring and clean up. (#1297)

* Rogue Legacy: More refactoring and clean up.

* Also marked Blacksmith as Progression as it's used in a rule.

* Remove extra newline.

* Prevent divide by zero type error.

* Scratch last commit, got the math mixed in my head.

* Clarified name of rule regarding percentage of stat upgrades.

* Move early vendors/architect creation into `create_items` logic.

* Rename parameter in `create_region`.

* Rename local var in `create_region`.

* Removed accidental links in Markdown docs.

* Refactor `create_region` signature and caller.

* Remove redundant if-else.

* Revert change to if-else, and moved item_pool to function instead of obj var.

* Rename LegacyLogic to RLLogic.

* Remove LogicMixin for rules.

worlds/rogue_legacy/docs/en_Rogue Legacy.md

@@ -3,7 +3,7 @@
 ## Where is the settings page?
 
 The [player settings page for this game](../player-settings) contains most of the options you need to 
-configure and export a config file. Some settings can only be made via YAML, but an explaination can be found in the
+configure and export a config file. Some settings can only be made in YAML, but an explanation can be found in the
 [template yaml here](../../../static/generated/configs/Rogue%20Legacy.yaml).
 
 ## What does randomization do to this game?
@@ -13,7 +13,6 @@ upgrade screen, bosses, and some special individual locations. The goal is to be
 zone bosses and then defeat The Fountain.
 
 ## What items and locations get shuffled?
-
 All the skill upgrades, class upgrades, runes packs, and equipment packs are shuffled in the manor upgrade screen, diary
 checks, chests and fairy chests, and boss rewards. Skill upgrades are also grouped in packs of 5 to make the finding of
 stats less of a chore. Runes and Equipment are also grouped together.
@@ -24,7 +23,6 @@ Some additional locations that can contain items are the Jukebox, the Portraits,
 
 Any of the items which can be shuffled may also be placed into another player's world. It is possible to choose to limit
 certain items to your own world.
-
 ## When the player receives an item, what happens?
 
 When the player receives an item, your character will hold the item above their head and display it to the world. It's
@@ -33,4 +31,4 @@ good for business!
 ## What do I do if I encounter a bug with the game?
 
 Please reach out to Phar#4444 on Discord or you can drop a bug report on the 
-[GitHub page for Rogue Legacy Randomizer](https://github.com/ThePhar/RogueLegacyRandomizer/issues/new?assignees=&labels=bug&template=report-an-issue---.md&title=%5BIssue%5D).
+[GitHub page for Rogue Legacy Randomizer](https://github.com/ThePhar/RogueLegacyRandomizer/issues/new?assignees=&labels=bug&template=report-an-issue---.md&title=%5BIssue%5D).

worlds/rogue_legacy/docs/rogue-legacy_en.md

@@ -2,8 +2,14 @@
 
 ## Required Software
 
-- Rogue Legacy Randomizer from
-  the [Rogue Legacy Randomizer Releases Page](https://github.com/ThePhar/RogueLegacyRandomizer/releases)
+- Rogue Legacy Randomizer from the
+  [Rogue Legacy Randomizer Releases Page](https://github.com/ThePhar/RogueLegacyRandomizer/releases)
+
+## Recommended Installation Instructions
+
+Please read the README file on the 
+[Rogue Legacy Randomizer GitHub](https://github.com/ThePhar/RogueLegacyRandomizer/blob/master/README.md) page for 
+up-to-date installation instructions.
 
 ## Configuring your YAML file
 
@@ -27,9 +33,3 @@ provides an alternative one to the default values.
 
 Once you have entered the required values, you go to Connect and then select Confirm on the "Ready to Start" screen. Now
 you're off to start your legacy!
-
-## Recommended Installation Instructions
-
-Please read the README file on the 
-[Rogue Legacy Randomizer GitHub](https://github.com/ThePhar/RogueLegacyRandomizer/blob/master/README.md) page for up to
-date installation instructions.