morgan/Grinch-AP
1
0
Fork 0
mirror of https://github.com/MarioSpore/Grinch-AP.git synced 2025-10-21 12:11:33 -06:00
Code Issues Packages Projects Releases Wiki Activity

SMZ3: Fix Junk Item Overflow (#5162)

Browse Source 
Removed `self.junkItemsNames = [item.Type.name for item in junkItems]` from `create_items` as that was pulling massive amounts of HeartPieces (because they're in junkItems in upstream) to be added if the start_inventory_from_pool was extensive. Getting more than 20 Heart Containers can lead to OHKO situations.

ETank was also removed as a junk item that can be used as filler in the earlier defined list of junk items that AP allows since you should only have 14 in the pool. It's not a problem to have more per se, but you really shouldn't have 27 of them in the pool, either. Ammo and such is much less of a problem to have crazy amounts of.
This commit is contained in:
Solidus Snake
2025-07-30 07:40:01 -04:00
committed by GitHub
parent 743501addc
commit 8a552e3639
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
worlds/smz3/__init__.py
View File

@@ -97,7 +97,6 @@ class SMZ3World(World):
ItemType.TwentyRupees, ItemType.TwentyRupees,
ItemType.FiftyRupees, ItemType.FiftyRupees,
ItemType.ThreeHundredRupees, ItemType.ThreeHundredRupees,
ItemType.ETank,
ItemType.Missile, ItemType.Missile,
ItemType.Super, ItemType.Super,
ItemType.PowerBomb ItemType.PowerBomb
@@ -231,7 +230,6 @@ class SMZ3World(World):
niceItems = TotalSMZ3Item.Item.CreateNicePool(self.smz3World) niceItems = TotalSMZ3Item.Item.CreateNicePool(self.smz3World)
junkItems = TotalSMZ3Item.Item.CreateJunkPool(self.smz3World) junkItems = TotalSMZ3Item.Item.CreateJunkPool(self.smz3World)
self.junkItemsNames = [item.Type.name for item in junkItems]
if (self.smz3World.Config.Keysanity): if (self.smz3World.Config.Keysanity):
progressionItems = self.progression + self.dungeon + self.keyCardsItems + self.SmMapsItems progressionItems = self.progression + self.dungeon + self.keyCardsItems + self.SmMapsItems