From 993d69cebce9bd5c75fcc26008b6071ad01c0c0e Mon Sep 17 00:00:00 2001
From: Fabian Dill <fabian.dill@web.de>
Date: Mon, 30 Mar 2020 07:46:40 +0200
Subject: [PATCH] improve gui checking

---
 Gui.py | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/Gui.py b/Gui.py
index 85839490..94b6e7c3 100755
--- a/Gui.py
+++ b/Gui.py
@@ -196,7 +196,16 @@ def guiMain(args=None):
 
     def RomSelect():
         rom = filedialog.askopenfilename(filetypes=[("Rom Files", (".sfc", ".smc")), ("All Files", "*")])
-        romVar.set(rom)
+        import Patch
+        try:
+            Patch.get_base_rom_bytes(rom)  # throws error on checksum fail
+        except Exception as e:
+            logging.exception(e)
+            messagebox.showerror(title="Error while reading ROM", message=str(e))
+        else:
+            romVar.set(rom)
+            romSelectButton['state'] = "disabled"
+            romSelectButton["text"] = "ROM verified"
     romSelectButton = Button(romDialogFrame, text='Select Rom', command=RomSelect)
 
     baseRomLabel.pack(side=LEFT)
@@ -464,12 +473,8 @@ def guiMain(args=None):
             elif type(v) is dict: # use same settings for every player
                 setattr(guiargs, k, {player: getattr(guiargs, k) for player in range(1, guiargs.multi + 1)})
         try:
-            if not guiargs.suppress_rom:
-                if not os.path.exists(guiargs.rom):
-                    raise FileNotFoundError(f"Could not find specified rom file {guiargs.rom}")
-                else:
-                    import Patch
-                    Patch.get_base_rom_bytes(guiargs.rom)  # throws error on checksum fail
+            if not guiargs.suppress_rom and not os.path.exists(guiargs.rom):
+                raise FileNotFoundError(f"Could not find specified rom file {guiargs.rom}")
             if guiargs.count is not None:
                 seed = guiargs.seed
                 for _ in range(guiargs.count):