Stardew Valley: Refactor buildings to use content packs (#4239)
* create building data object and rename ItemSource to Source to be more generic # Conflicts: # worlds/stardew_valley/content/game_content.py # Conflicts: # worlds/stardew_valley/data/artisan.py # worlds/stardew_valley/data/game_item.py # worlds/stardew_valley/data/harvest.py # worlds/stardew_valley/data/shop.py * remove compound sources, replace by other requirements which already handle this usecase * add coops to content packs * add building progression in game features * add shippping bin to starting building; remove has_house * replace config check with feature * add other buildings in content packs * not passing * tests passes, unbelievable * use newly create methods more * use new assets to ease readability * self review * fix flake8 maybe * properly split rule for mapping cave systems * fix tractor garage name * self review * add upgrade_from to farm house buldings * don't override building name variable in logic * remove has_group from buildings * mark some items easy in grinding logic so blueprints buildings can be in more early spheres * move stuff around to maybe avoid future conflicts cuz I have like 10 PRs opened right now * remove price_multiplier, turns out it's unused during generation * disable shop source for mapping cave systems * bunch of code review changes * add petbowl and farmhouse to autobuilding * set min easy items to 300 * fix farm type
This commit is contained in:
@@ -47,12 +47,8 @@ class TestFriendsanityDatingRules(SVTestBase):
|
||||
for i in range(1, max_reachable + 1):
|
||||
if i % step != 0 and i != 14:
|
||||
continue
|
||||
location = f"{prefix}{npc} {i}{suffix}"
|
||||
can_reach = self.world.logic.region.can_reach_location(location)(self.multiworld.state)
|
||||
self.assertTrue(can_reach, f"Should be able to earn relationship up to {i} hearts")
|
||||
self.assert_can_reach_location(f"{prefix}{npc} {i}{suffix}")
|
||||
for i in range(max_reachable + 1, 14 + 1):
|
||||
if i % step != 0 and i != 14:
|
||||
continue
|
||||
location = f"{prefix}{npc} {i}{suffix}"
|
||||
can_reach = self.world.logic.region.can_reach_location(location)(self.multiworld.state)
|
||||
self.assertFalse(can_reach, f"Should not be able to earn relationship up to {i} hearts")
|
||||
self.assert_cannot_reach_location(f"{prefix}{npc} {i}{suffix}")
|
||||
|
||||
Reference in New Issue
Block a user