Core: Attribute per slot random directly to the World and discourage using MultiWorld's random (#1649)

* add a random object to the World

* use it in The Messenger

* the worlds don't exist until the end of set options

* set seed in lttp tests

* use world.random for shop shuffle

worlds/alttp/test/dungeons/TestDungeon.py

@@ -14,6 +14,7 @@ from worlds import AutoWorld
 class TestDungeon(unittest.TestCase):
     def setUp(self):
         self.multiworld = MultiWorld(1)
+        self.multiworld.set_seed(None)
         args = Namespace()
         for name, option in AutoWorld.AutoWorldRegister.world_types["A Link to the Past"].option_definitions.items():
             setattr(args, name, {1: option.from_any(option.default)})

worlds/alttp/test/inverted/TestInverted.py

@@ -15,6 +15,7 @@ from worlds import AutoWorld
 class TestInverted(TestBase):
     def setUp(self):
         self.multiworld = MultiWorld(1)
+        self.multiworld.set_seed(None)
         args = Namespace()
         for name, option in AutoWorld.AutoWorldRegister.world_types["A Link to the Past"].option_definitions.items():
             setattr(args, name, {1: option.from_any(option.default)})

worlds/alttp/test/inverted/TestInvertedBombRules.py

@@ -15,6 +15,7 @@ class TestInvertedBombRules(unittest.TestCase):
 
     def setUp(self):
         self.multiworld = MultiWorld(1)
+        self.multiworld.set_seed(None)
         self.multiworld.mode[1] = "inverted"
         args = Namespace
         for name, option in AutoWorld.AutoWorldRegister.world_types["A Link to the Past"].option_definitions.items():

worlds/alttp/test/inverted_minor_glitches/TestInvertedMinor.py

@@ -16,6 +16,7 @@ from worlds import AutoWorld
 class TestInvertedMinor(TestBase):
     def setUp(self):
         self.multiworld = MultiWorld(1)
+        self.multiworld.set_seed(None)
         args = Namespace()
         for name, option in AutoWorld.AutoWorldRegister.world_types["A Link to the Past"].option_definitions.items():
             setattr(args, name, {1: option.from_any(option.default)})

worlds/alttp/test/inverted_owg/TestInvertedOWG.py

@@ -17,6 +17,7 @@ from worlds import AutoWorld
 class TestInvertedOWG(TestBase):
     def setUp(self):
         self.multiworld = MultiWorld(1)
+        self.multiworld.set_seed(None)
         args = Namespace()
         for name, option in AutoWorld.AutoWorldRegister.world_types["A Link to the Past"].option_definitions.items():
             setattr(args, name, {1: option.from_any(option.default)})

worlds/alttp/test/minor_glitches/TestMinor.py

@@ -16,6 +16,7 @@ from worlds import AutoWorld
 class TestMinor(TestBase):
     def setUp(self):
         self.multiworld = MultiWorld(1)
+        self.multiworld.set_seed(None)
         args = Namespace()
         for name, option in AutoWorld.AutoWorldRegister.world_types["A Link to the Past"].option_definitions.items():
             setattr(args, name, {1: option.from_any(option.default)})

worlds/alttp/test/owg/TestVanillaOWG.py

@@ -17,6 +17,7 @@ from worlds import AutoWorld
 class TestVanillaOWG(TestBase):
     def setUp(self):
         self.multiworld = MultiWorld(1)
+        self.multiworld.set_seed(None)
         args = Namespace()
         for name, option in AutoWorld.AutoWorldRegister.world_types["A Link to the Past"].option_definitions.items():
             setattr(args, name, {1: option.from_any(option.default)})

worlds/alttp/test/vanilla/TestVanilla.py

@@ -15,6 +15,7 @@ from worlds import AutoWorld
 class TestVanilla(TestBase):
     def setUp(self):
         self.multiworld = MultiWorld(1)
+        self.multiworld.set_seed(None)
         args = Namespace()
         for name, option in AutoWorld.AutoWorldRegister.world_types["A Link to the Past"].option_definitions.items():
             setattr(args, name, {1: option.from_any(option.default)})