From ac80ed4d1581d5b4e0876edaea910119b1eefc9d Mon Sep 17 00:00:00 2001 From: morgan Date: Mon, 3 Nov 2025 21:49:29 -0700 Subject: [PATCH] Fixed issue with goal placement. Added warning for if item an item is broken to report to the Discord thread --- worlds/grinch/Client.py | 7 +++++++ worlds/grinch/__init__.py | 4 +++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/worlds/grinch/Client.py b/worlds/grinch/Client.py index c37f9947..20c9e7f2 100644 --- a/worlds/grinch/Client.py +++ b/worlds/grinch/Client.py @@ -253,6 +253,13 @@ class GrinchClient(BizHawkClient): for item_received in new_items_only: local_item = ctx.item_names.lookup_in_game(item_received.item) + + if "unknown item" in local_item.lower(): + logger.warning( + f"Unknown item triggered in pool. Item: {local_item}\nIf you see this message, please report it in the Grinch thread in the AP Discord." + ) + continue + grinch_item_ram_data = ALL_ITEMS_TABLE[local_item] for addr_to_update in grinch_item_ram_data.update_ram_addr: diff --git a/worlds/grinch/__init__.py b/worlds/grinch/__init__.py index 6d212531..68d569b8 100644 --- a/worlds/grinch/__init__.py +++ b/worlds/grinch/__init__.py @@ -47,7 +47,9 @@ class GrinchWorld(World): entry = GrinchLocation(self.player, location, region, data) if location == "MC - Sleigh Ride - Neutralizing Santa": - entry.place_locked_item(Item("Goal", ItemClassification.progression, data.id, self.player)) + entry.place_locked_item( + Item("Goal", ItemClassification.progression, GrinchItem.get_apid(data.id), self.player) + ) region.locations.append(entry)