Multiple: Followed a rabbit hole of moving LttP Rom generation to AutoWorld

Generator: Re-allow names with spaces (and see what breaks)
Generator: Removed teams (Note that teams are intended to move from a generation step feature to a server runtime feature, allowing dynamic creation of an already generated MW)
LttP: All Rom Options are now on the new system
LttP: palette option "random" is now called "good"
LttP: Roms are now created as part of the general output file creation step
LttP: disable Music is now Music, removing potential double negatives
LttP & Factorio: Progressive option random is now grouped_random
LttP: Enemy damage option random is now Enemy damage: chaos

worlds/alttp/__init__.py

@@ -1,5 +1,7 @@
 import random
 import logging
+import os
+import threading
 
 from BaseClasses import Item, CollectionState
 from .SubClasses import ALttPItem
@@ -11,6 +13,8 @@ from .Rules import set_rules
 from .ItemPool import generate_itempool
 from .Shops import create_shops
 from .Dungeons import create_dungeons
+from .Rom import LocalRom, patch_rom, patch_race_rom, patch_enemizer, apply_rom_settings, get_hash_string
+import Patch
 
 from .InvertedRegions import create_inverted_regions, mark_dark_world_regions
 from .EntranceShuffle import link_entrances, link_inverted_entrances, plando_connect
@@ -37,6 +41,8 @@ class ALTTPWorld(World):
     create_items = generate_itempool
 
     def create_regions(self):
+        self.rom_name_available_event = threading.Event()
+
         player = self.player
         world = self.world
         if world.open_pyramid[player] == 'goal':
@@ -175,6 +181,67 @@ class ALTTPWorld(World):
         from .Dungeons import fill_dungeons_restrictive
         fill_dungeons_restrictive(world)
 
+    def generate_output(self, output_directory: str):
+        world = self.world
+        player = self.player
+
+        use_enemizer = (world.boss_shuffle[player] != 'none' or world.enemy_shuffle[player]
+                        or world.enemy_health[player] != 'default' or world.enemy_damage[player] != 'default'
+                        or world.shufflepots[player] or world.bush_shuffle[player]
+                        or world.killable_thieves[player])
+
+        rom = LocalRom(world.alttp_rom)
+
+        patch_rom(world, rom, player, use_enemizer)
+
+        if use_enemizer:
+            patch_enemizer(world, player, rom, world.enemizer, output_directory)
+
+        if world.is_race:
+            patch_race_rom(rom, world, player)
+
+        world.spoiler.hashes[player] = get_hash_string(rom.hash)
+
+        palettes_options = {
+            'dungeon': world.uw_palettes[player],
+            'overworld': world.ow_palettes[player],
+            'hud': world.hud_palettes[player],
+            'sword': world.sword_palettes[player],
+            'shield': world.shield_palettes[player],
+            'link': world.link_palettes[player]
+        }
+        palettes_options = {key: option.current_key for key, option in palettes_options.items()}
+
+        apply_rom_settings(rom, world.heartbeep[player].current_key,
+                           world.heartcolor[player].current_key,
+                           world.quickswap[player],
+                           world.menuspeed[player].current_key,
+                           world.music[player],
+                           world.sprite[player],
+                           palettes_options, world, player, True,
+                           reduceflashing=world.reduceflashing[player] or world.is_race,
+                           triforcehud=world.triforcehud[player].current_key)
+
+        outfilepname = f'_P{player}'
+        outfilepname += f"_{world.player_name[player].replace(' ', '_')}" \
+            if world.player_name[player] != 'Player%d' % player else ''
+
+        rompath = os.path.join(output_directory, f'AP_{world.seed_name}{outfilepname}.sfc')
+        rom.write_to_file(rompath, hide_enemizer=True)
+        Patch.create_patch_file(rompath, player=player, player_name=world.player_name[player])
+        os.unlink(rompath)
+        self.rom_name = rom.name
+        self.rom_name_available_event.set()
+
+    def modify_multidata(self, multidata: dict):
+        import base64
+        # wait for self.rom_name to be available.
+        self.rom_name_available_event.wait()
+        new_name = base64.b64encode(bytes(self.rom_name)).decode()
+        payload = multidata["connect_names"][self.world.player_name[self.player]]
+        multidata["connect_names"][new_name] = payload
+        del (multidata["connect_names"][self.world.player_name[self.player]])
+
     def get_required_client_version(self) -> tuple:
         return max((0, 1, 4), super(ALTTPWorld, self).get_required_client_version())