morgan/Grinch-AP
1
0
Fork 0
mirror of https://github.com/MarioSpore/Grinch-AP.git synced 2025-10-21 12:11:33 -06:00
Code Issues Packages Projects Releases Wiki Activity

Settings: warn for broken worlds instead of crashing (#4438)

Browse Source 
note: i swear the issue was an importerror but i could only get attributeerrors on the getattr() call, maybe we want to check for both?
This commit is contained in:
qwint
2025-08-10 10:23:39 -05:00
committed by GitHub
parent c34c00baa4
commit cdde38fdc9
1 changed files with 6 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
settings.py
View File

@@ -754,7 +754,12 @@ class Settings(Group):
return super().__getattribute__(key) return super().__getattribute__(key)
# directly import world and grab settings class # directly import world and grab settings class
world_mod, world_cls_name = _world_settings_name_cache[key].rsplit(".", 1) world_mod, world_cls_name = _world_settings_name_cache[key].rsplit(".", 1)
world = cast(type, getattr(__import__(world_mod, fromlist=[world_cls_name]), world_cls_name)) try:
world = cast(type, getattr(__import__(world_mod, fromlist=[world_cls_name]), world_cls_name))
except AttributeError:
import warnings
warnings.warn(f"World {world_cls_name} failed to initialize properly.")
return super().__getattribute__(key)
assert getattr(world, "settings_key") == key assert getattr(world, "settings_key") == key
try: try:
cls_or_name = world.__annotations__["settings"] cls_or_name = world.__annotations__["settings"]