morgan/Grinch-AP
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Stardew Valley: Use new asserts in tests (#4621)

Browse Source 
* changes

* cherry pick stuff

* use newly create methods more

* use new assets to ease readability

* remove unneeded assert

* add assert region adapters

* use new asserts yay

* self review

* self review

* review

* replace parrot express with transportation constant

* bullshit commit again

* revert a bunch of off topic changes

* these changes seems to be on topic

* revert some undesired merge changes

* review imports

* use type instead of instance in some options

* properly return super

* review

* change one str to use a constnat
This commit is contained in:
Jérémie Bolduc
2025-08-31 10:21:23 -04:00
committed by GitHub
parent 893acd2f02
commit cdf7165ab4
5 changed files with 81 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
worlds/stardew_valley/test/TestGeneration.py
View File

@@ -131,15 +131,13 @@ class TestProgressiveElevator(SVTestBase):
items_for_115 = self.generate_items_for_mine_115()
last_elevator = self.get_item_by_name("Progressive Mine Elevator")
self.collect(items_for_115)
floor_115 = self.multiworld.get_region("The Mines - Floor 115", self.player)
floor_120 = self.multiworld.get_region("The Mines - Floor 120", self.player)
self.assertTrue(floor_115.can_reach(self.multiworld.state))
self.assertFalse(floor_120.can_reach(self.multiworld.state))
self.assert_can_reach_region(Region.mines_floor_115)
self.assert_cannot_reach_region(Region.mines_floor_120)
self.collect(last_elevator)
self.assertTrue(floor_120.can_reach(self.multiworld.state))
self.assert_can_reach_region(Region.mines_floor_120)
def generate_items_for_mine_115(self) -> List[Item]:
pickaxes = [self.get_item_by_name("Progressive Pickaxe")] * 2
@@ -171,27 +169,24 @@ class TestSkullCavernLogic(SVTestBase):
items_for_skull_50 = self.generate_items_for_skull_50()
items_for_skull_100 = self.generate_items_for_skull_100()
self.collect(items_for_115)
floor_115 = self.multiworld.get_region(Region.mines_floor_115, self.player)
skull_25 = self.multiworld.get_region(Region.skull_cavern_25, self.player)
skull_75 = self.multiworld.get_region(Region.skull_cavern_75, self.player)
self.assertTrue(floor_115.can_reach(self.multiworld.state))
self.assertFalse(skull_25.can_reach(self.multiworld.state))
self.assertFalse(skull_75.can_reach(self.multiworld.state))
self.assert_can_reach_region(Region.mines_floor_115)
self.assert_cannot_reach_region(Region.skull_cavern_25)
self.assert_cannot_reach_region(Region.skull_cavern_75)
self.remove(items_for_115)
self.collect(items_for_skull_50)
self.assertTrue(floor_115.can_reach(self.multiworld.state))
self.assertTrue(skull_25.can_reach(self.multiworld.state))
self.assertFalse(skull_75.can_reach(self.multiworld.state))
self.assert_can_reach_region(Region.mines_floor_115)
self.assert_can_reach_region(Region.skull_cavern_25)
self.assert_cannot_reach_region(Region.skull_cavern_75)
self.remove(items_for_skull_50)
self.collect(items_for_skull_100)
self.assertTrue(floor_115.can_reach(self.multiworld.state))
self.assertTrue(skull_25.can_reach(self.multiworld.state))
self.assertTrue(skull_75.can_reach(self.multiworld.state))
self.assert_can_reach_region(Region.mines_floor_115)
self.assert_can_reach_region(Region.skull_cavern_25)
self.assert_can_reach_region(Region.skull_cavern_75)
def generate_items_for_mine_115(self) -> List[Item]:
pickaxes = [self.get_item_by_name("Progressive Pickaxe")] * 2