From d146d90131a5087698cbf67a9fc085ce3da2f362 Mon Sep 17 00:00:00 2001 From: NewSoupVi <57900059+NewSoupVi@users.noreply.github.com> Date: Mon, 25 Aug 2025 17:52:04 +0200 Subject: [PATCH] Core: Fix Priority Fill *not* crashing when it should, in cases where there is no deprioritized progression #5363 --- Fill.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Fill.py b/Fill.py index 1cc1278f..7a079fbc 100644 --- a/Fill.py +++ b/Fill.py @@ -549,10 +549,12 @@ def distribute_items_restrictive(multiworld: MultiWorld, if prioritylocations and regular_progression: # retry with one_item_per_player off because some priority fills can fail to fill with that optimization # deprioritized items are still not in the mix, so they need to be collected into state first. + # allow_partial should only be set if there is deprioritized progression to fall back on. priority_retry_state = sweep_from_pool(multiworld.state, deprioritized_progression) fill_restrictive(multiworld, priority_retry_state, prioritylocations, regular_progression, single_player_placement=single_player, swap=False, on_place=mark_for_locking, - name="Priority Retry", one_item_per_player=False, allow_partial=True) + name="Priority Retry", one_item_per_player=False, + allow_partial=bool(deprioritized_progression)) if prioritylocations and deprioritized_progression: # There are no more regular progression items that can be placed on any priority locations.