morgan/Grinch-AP
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Stardew Valley: Fix a logic bug and a documentation typo (#1722)

Browse Source 
Typo in the documentation
Logic error for help wanted quests
This commit is contained in:
agilbert1412
2023-04-16 05:22:33 -04:00
committed by GitHub
parent 50d9ab041a
commit ea03c90152
6 changed files with 103 additions and 75 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
worlds/stardew_valley/test/TestBundles.py
View File

@@ -1,16 +1,30 @@
import unittest
from ..data.bundle_data import all_bundle_items
from ..data.bundle_data import all_bundle_items, quality_crops_items
class TestBundles(unittest.TestCase):
def test_all_bundle_items_have_3_parts(self):
for bundle_item in all_bundle_items:
name = bundle_item.item.name
assert len(name) > 0
id = bundle_item.item.item_id
assert (id > 0 or id == -1)
amount = bundle_item.amount
assert amount > 0
quality = bundle_item.quality
assert quality >= 0
with self.subTest(bundle_item.item.name):
self.assertGreater(len(bundle_item.item.name), 0)
id = bundle_item.item.item_id
self.assertGreaterEqual(id, -1)
self.assertNotEqual(id, 0)
self.assertGreater(bundle_item.amount, 0)
self.assertGreaterEqual(bundle_item.quality, 0)
def test_quality_crops_have_correct_amounts(self):
for bundle_item in quality_crops_items:
with self.subTest(bundle_item.item.name):
name = bundle_item.item.name
if name == "Sweet Gem Berry" or name == "Ancient Fruit":
self.assertEqual(bundle_item.amount, 1)
else:
self.assertEqual(bundle_item.amount, 5)
def test_quality_crops_have_correct_quality(self):
for bundle_item in quality_crops_items:
with self.subTest(bundle_item.item.name):
self.assertEqual(bundle_item.quality, 2)