Stardew Valley: Move progressive tool options handling in features (#4374)

* create tool progression feature and unwrap option

* replace option usage with calling feature

* add comment explaining why some logic is a weird place

* replace item creation logic with feature

* self review and add unit tests

* rename test cuz I named them too long

* add a test for the trash can useful stuff cuz I thought there was a bug but turns out it works

* self review again

* remove price_multiplier, turns out it's unused during generation

* damn it 3.11 why are you like this

* use blacksmith region when checking vanilla tools

* fix rule

* move can mine using in tool logic

* remove changes to performance test

* properly set the option I guess

* properly set options 2

* that's what happen when you code too late

worlds/stardew_valley/strings/entrance_names.py

@@ -194,10 +194,15 @@ class LogicEntrance:
     island_cooking = "Island Cooking"
     shipping = "Use Shipping Bin"
     watch_queen_of_sauce = "Watch Queen of Sauce"
-    blacksmith_copper = "Upgrade Copper Tools"
-    blacksmith_iron = "Upgrade Iron Tools"
-    blacksmith_gold = "Upgrade Gold Tools"
-    blacksmith_iridium = "Upgrade Iridium Tools"
+
+    @staticmethod
+    def blacksmith_upgrade(material: str) -> str:
+        return f"Upgrade {material} Tools"
+
+    blacksmith_copper = blacksmith_upgrade("Copper")
+    blacksmith_iron = blacksmith_upgrade("Iron")
+    blacksmith_gold = blacksmith_upgrade("Gold")
+    blacksmith_iridium = blacksmith_upgrade("Iridium")
 
     grow_spring_crops = "Grow Spring Crops"
     grow_summer_crops = "Grow Summer Crops"