Stardew Valley: Move progressive tool options handling in features (#4374)

* create tool progression feature and unwrap option

* replace option usage with calling feature

* add comment explaining why some logic is a weird place

* replace item creation logic with feature

* self review and add unit tests

* rename test cuz I named them too long

* add a test for the trash can useful stuff cuz I thought there was a bug but turns out it works

* self review again

* remove price_multiplier, turns out it's unused during generation

* damn it 3.11 why are you like this

* use blacksmith region when checking vanilla tools

* fix rule

* move can mine using in tool logic

* remove changes to performance test

* properly set the option I guess

* properly set options 2

* that's what happen when you code too late

worlds/stardew_valley/strings/region_names.py

@@ -159,10 +159,15 @@ class LogicRegion:
     kitchen = "Kitchen"
     shipping = "Shipping"
     queen_of_sauce = "The Queen of Sauce"
-    blacksmith_copper = "Blacksmith Copper Upgrades"
-    blacksmith_iron = "Blacksmith Iron Upgrades"
-    blacksmith_gold = "Blacksmith Gold Upgrades"
-    blacksmith_iridium = "Blacksmith Iridium Upgrades"
+
+    @staticmethod
+    def blacksmith_upgrade(material: str) -> str:
+        return f"Blacksmith {material} Upgrades"
+
+    blacksmith_copper = blacksmith_upgrade("Copper")
+    blacksmith_iron = blacksmith_upgrade("Iron")
+    blacksmith_gold = blacksmith_upgrade("Gold")
+    blacksmith_iridium = blacksmith_upgrade("Iridium")
 
     spring_farming = "Spring Farming"
     summer_farming = "Summer Farming"