* Core: fix settings API for removal of Python 3.8, 3.9
This is fixing 2 problems:
- The `World` class has the annotation:
`settings: ClassVar[Optional["Group"]]`
so `MyWorld.settings` should not raise an exception like it does for some worlds.
With the `Optional` there, it looks like it should return `None` for the worlds that don't use it. So that's what I changed it to.
- `Group.update` had some code that required `typing.Union` instead of the Python 3.10 `|` for unions.
added unit test for this fix
added change in Zillion that I used to discover this problem and used it to test the test
* fix copy-pasted stuff
* tuple instead of set
Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
---------
Co-authored-by: black-sliver <59490463+black-sliver@users.noreply.github.com>
* Split elevators come to you
* .
* unit test
* mypy stuff
* Fine. I'll fix the fcking commented out code. Happy?
* ruff
* """""Backwards compatibility"""""
* ruff
* make it look better
* #
* fix presets
* fix a unit test
* Make that explicit in the code
* Improve description
This means its diff will be collapsed by default on PRs that change it, because it is an "auto generated" file that does not need to be looked at by reviewers
* Pokemon Emerald: Rework location tags to categories
* Pokemon Emerald: Rework item tags, automatically create item/location groups
* Pokemon Emerald: Move item and location groups to data.py, add some regional location groups
* Map Regions
* Pokemon Emerald: Fix up location groups
* Pokemon Emerald: Move groups to their own file
* Pokemon Emerald: Add meta groups for location groups
* Pokemon Emerald: Fix has_group using updated item group name
* Pokemon Emerald: Add sanity check for maps in location groups
* Pokemon Emerald: Remove missed use of location.tags
* Pokemon Emerald: Reclassify white and black flutes
* Pokemon Emerald: Update changelog
* Pokemon Emerald: Adjust changelog
---------
Co-authored-by: Tsukino <16899482+Tsukino-uwu@users.noreply.github.com>
* Add timestamps to logging for improved debugging
* Add datetime to general logging; particularly useful for large seeds.
* Move console timestamps from Main to Utils.init_logging (better location)
* Update Main.py
remove spurious blank line
Co-authored-by: Nicholas Saylor <79181893+nicholassaylor@users.noreply.github.com>
---------
Co-authored-by: Zach Parks <zach@alliware.com>
Co-authored-by: Nicholas Saylor <79181893+nicholassaylor@users.noreply.github.com>
* Actually take item from pool when plandoing from_pool
* Remove the awkward index thing
* oops left a comment in
* there wasn't a line break here before
* Only remove if actually found, check against player number
* oops
* Go back to index based system so we can just remove at the end
* Comment
* Fix error on None
* Update Fill.py
Co-authored-by: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com>
---------
Co-authored-by: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com>
* Add Start Inventory From Pool
Just as the title implies
* Update Options.py
Fix dataclass since I had just pulled changes from prior options.py without seeing if anythin had changed
* Update Options.py
One more time with feeling
* Update worlds/smz3/Options.py
Co-authored-by: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com>
---------
Co-authored-by: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com>
* Introduce 'Hint Priority' concept
* fix error when sorting hints while not connected
* fix 'found' -> 'status' kivy stuff
* remove extraneous warning
this warning fired if you clicked to select or toggle priority of any hint, as you weren't clicking on the header...
* skip scanning individual header widgets when not clicking on the header
* update hints on disconnection
* minor cleanup
* minor fixes/cleanup
* fix: hints not updating properly for receiving player
* update re: review
* 'type() is' -> 'isinstance()'
* cleanup, re: Jouramie's review
* Change 'priority' to 'status', add 'Unspecified' and 'Avoid' statuses, update colors
* cleanup
* move dicts out of functions
* fix: new hints being returned when hint already exists
* fix: show `Found` properly when hinting already-found hints
* import `Hint` and `HintStatus` directly from `NetUtils`
* Default any hinted `Trap` item to be classified as `Avoid` by default
* add some sanity checks
* re: Vi's feedback
* move dict out of function
* Update kvui.py
* remove unneeded dismiss message
* allow lclick to drop hint status dropdown
* underline hint statuses to indicate clickability
* only underline clickable statuses
* Update kvui.py
* Update kvui.py
---------
Co-authored-by: Silvris <58583688+Silvris@users.noreply.github.com>
Co-authored-by: NewSoupVi <57900059+NewSoupVi@users.noreply.github.com>
* sm64ex: add option groups
* sm64ex: rename sanity options group to item options
* sm64ex: rename sanity options group to logic options
* sm64ex: seperate star costs from goal options and add entrance rando to logic options
* sm64ex: seperate ability options from logic options group
* Core: Fix playthrough only checking half of the sphere 0 items
The lists of precollected items were being mutated while iterating those
same lists, causing playthrough to skip checking half of the sphere 0
advancement items.
This patch ensures the lists are copied before they are iterated.
* Replace chain.from_iterable with two for loops for better clarity
Added a comment to `multiworld.push_precollected(item)` to explain that
it is also modifying `precollected_items`.
