* uses itempool count vs unfilled location count instead of counting prog_items values which could have custom counters
* move unfilled location check to before can_reach
* add tests for successful minimal GER call with extra collect override prog_items in the pool to regression test issue fixed in this PR
* Potential fix for attack issue
* also put the lazy version of the swamp fix in for good measure
* fix extra line
* now it is good
* Add the test, roll the other PR into this one
* Make the test exception more useful
* Remove debug print
* Combat logic fixed?
* Move a few areas to before well instead of east forest
* Put in qwint's suggestions in test
* Implement qwint's suggestions in combat_logic.py
* Implement qwint's suggestions for combat_logic.py
* Fix typo
* Remove experimental from combat logic description
* Remove copy_mixin again
* Add comment about copy_mixin
* Use a more proper random
* Some optimizations from Vi's comments
* Core: Replace generator creation/iteration in CollectionState methods
Using generators in these functions incurs overhead to create the new
generator instance, call the `any`/`all`/`sum` function and have the
`any`/`all`/`sum` function iterate the generator, which in turn iterates
the iterable.
Replacing the use of generators with for loops is faster.
Getting `self.prog_items[player]` once in advance also improves
performance of iterating longer iterables.
* Add comment on the choice of for loops instead of any()/all()/sum()
* [LADX] Fix minimal accessibility
* allow_partial for minimal accessibility
* create the correct partial_all_state
* skip our prefills rather than removing after
* dont rebuild our prefill list
---------
Co-authored-by: threeandthreee <a.l.nordstrom@gmail.com>
* Tests: massively improve the memory leak test performance
With the growing number of worlds, GC becomes the bottleneck and slows down the test.
* Tests: fix typing in general/test_memory
* MultiServer: add NoText tag and handling
* MultiServer: deprecate and warn for uncompressed connections
* MultiServer: fix missing space in no compression warning
* - Unrolled and improved the structure of the test for Mods + ER, to improve total performance and performance on individual tests for threading purposes
* Use | instead of Union[]
Co-authored-by: Jouramie <16137441+Jouramie@users.noreply.github.com>
* - Remove unused using
---------
Co-authored-by: Jouramie <16137441+Jouramie@users.noreply.github.com>
* adds docstring to make_gui describing what things you might want to change without dealing with kivy/kvui directly (there are better places to document those)
* Update CommonClient.py
Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>
* Update CommonClient.py
Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>
---------
Co-authored-by: Doug Hoskisson <beauxq@users.noreply.github.com>
