* implement tabs as NavigationBar
* update the underline bar with the screen manager
* remove some unneeded kv
* remove the underline in favor of a full tab highlight
* fix insert transitions
* use on_release instead of on_press
* minor cleanup
* add remove_client_tab and add a caller to the NavigationBar for back compat
* unused imports
* Update kvui.py
---------
Co-authored-by: Silvris <58583688+Silvris@users.noreply.github.com>
Co-authored-by: NewSoupVi <57900059+NewSoupVi@users.noreply.github.com>
* gift version 3
* update settings usage
* that really has just been broken this entire time
* remove unnecessary print
* Update client.py
* fix random flavor handling
* fix incorrect sender/receiver
---------
Co-authored-by: Exempt-Medic <60412657+Exempt-Medic@users.noreply.github.com>
* Fixing open waters urns not breakable with nature forms logic bug
* Using list in comprehension only when useful
* Replacing damaging items by a constant
* Removing comprehension list creating from lambda
* Fix Branch (Not Crow)
* Oops
* Mark Aldrich Ruby as missable
* Expand comment
* Short circuit
* Mark Twin Dragon Greatshield as missable
* Add missable cause
A couple of Entrance access rules were checking for being able to reach
a Location, but a Location first checks for being able to reach its
parent Region, so it needs to be registered that access to that parent
Region can give access to the Entrance.
The `Behind Rocks` and `Pickaxe Hard Cave` Entrances require being able
to reach the `Cut Content` region, but no indirect conditions were being
registered for this region.
The `set_lfod_self_obtained_items_rules` function was also using a
`world` parameter that was actually expecting a `MultiWorld` instance,
so I have renamed it for clarity and updated the function to use
`world.get_entrance()` rather than `multiworld.get_entrance()`.
Much of the rest of the file passes `MultiWorld` instances to `world`
parameters, but fixing all of these is out of the scope of the changes
in this patch, so has not been included.
* move to playercontainer
* moves patch_file_ending handling to APPlayerContainer and updates the worlds using it to define their extensions
* give oot a patch_file_ending as well
- Cleans up a few missed references in the setup guide.
- Refactors Options class to use metaclass and decorators to enforce friendly limits on multiple levels.
- Templates generated from the website, even ones with `random` should not fail generation because the website will only allow values inside the friendly limits.
- _Uploaded_ yamls to the website with `random`, should also now respect friendly limits without the need for `random-range` shenanigans.
- _Uploaded_ yamls to the website, or yamls that are used to generate locally, that have hard-defined values outside the friendly limits, will be clamped/dragged/massaged into those limits (with logged warnings).
- Removed an early completion goal that was playing havoc with fill. Not enough people seem to use this goal, so its loss will not be mourned.
