NewSoupVi 7bdaaa25c1 Core: Prevent worlds from using LogicMixin incorrectly (having class variables without an init_mixin) (#3974) ...

* Core: Prevent people from using LogicMixin incorrectly

There's a world that ran into some issues because it defined its custom LogicMixin variables at the class level.

This caused "instance bleed" when new CollectionState objects were created.

I don't think there is ever a reason to have a non-function class variable on LogicMixin without also having `init_mixin`, so this asserts that this is the case.

Tested:
Doesn't fail any current worlds
Correctly fails the world in question

Also, not gonna call out that world because it was literally my fault for explaining it to them wrong :D

* Verbose af

* Update AutoWorld.py

2025-04-05 18:06:30 +02:00

..

_bizhawk

Core/Various Worlds: Fix crash/freeze with unicode characters (#4671)

2025-03-14 08:24:37 +01:00

_sc2common

Core: ensure requirements files end on newline (#4761)

2025-03-24 22:26:30 +01:00

adventure

Adventure: Optimize imports (#4300)

2025-01-12 19:00:20 +01:00

ahit

Core/Various Worlds: Fix crash/freeze with unicode characters (#4671)

2025-03-14 08:24:37 +01:00

alttp

WebHost: Standardize some 404 redirects (#4642)

2025-04-04 23:11:45 +02:00

apsudoku

APSudoku: Update setup guide, remove extraneous options page link (#3849)

2024-08-29 08:12:58 +02:00

aquaria

WebHost: Standardize some 404 redirects (#4642)

2025-04-04 23:11:45 +02:00

archipidle

ArchipIDLE 2024 (#3079)

2024-04-12 00:32:10 -04:00

blasphemous

Blasphemous: Restrict right half of map start locations to hard difficulty only (#4002)

2025-03-08 11:59:35 -05:00

bomb_rush_cyberfunk

Bomb Rush Cyberfunk: Fix Coil quest being in glitched logic too early (#3720)

2024-07-31 17:32:51 +02:00

bumpstik

Bumper Stickers: Update tests to bases.py #4137

2024-11-06 09:37:36 +01:00

celeste64

Celeste 64: v1.3 Content Update (#4581)

2025-03-17 02:46:34 +01:00

checksfinder

Checksfinder: clean up setup guide intro and change ownership #4147

2024-11-07 10:35:12 +01:00

civ_6

Civ6: Sanitize player/item values before they go in the XML (#4755)

2025-04-01 18:09:59 +02:00

clique

WebHost: Standardize some 404 redirects (#4642)

2025-04-04 23:11:45 +02:00

cv64

CV64: Fix some unrandomized locations containing unintended items on specific settings (#4728)

2025-04-01 12:37:49 -04:00

cvcotm

CVCotM: Fix DeathLinks sent by a different instance of the same slot not being received. (#4726)

2025-04-05 10:27:51 -04:00

dark_souls_3

DS3: Remove the outdated French translation of the setup docs (#4700)

2025-03-08 01:45:52 +01:00

dkc3

DKC3: Remove unused variables and imports #4302

2025-01-14 10:49:30 +01:00

dlcquest

DLC Quest: Fix more items than location with non existing start inventory (#4735)

2025-04-05 08:19:54 -04:00

doom_1993

id Tech 1 games: Logic updates (Feb '25) (#4677)

2025-03-29 17:32:33 +01:00

doom_ii

id Tech 1 games: Logic updates (Feb '25) (#4677)

2025-03-29 17:32:33 +01:00

factorio

Factorio: fix energylink type back to int (#4768)

2025-03-28 00:28:10 +01:00

faxanadu

Faxanadu: Fix generations with itemlinks (#4395)

2025-01-13 18:35:01 -05:00

ff1

Core: Remove Universally Unique ID Requirements (Per-Game Data Packages) (#1933)

2024-06-01 06:07:13 -05:00

ffmq

WebHost: Standardize some 404 redirects (#4642)

2025-04-04 23:11:45 +02:00

generic

Docs: Clarify !alias commands in commands_en.md (#4426)

2025-01-06 09:42:18 -05:00

heretic

id Tech 1 games: Logic updates (Feb '25) (#4677)

2025-03-29 17:32:33 +01:00

hk

Hollow Knight: Include Lumafly links to install mods in docs (#4745)

2025-03-20 11:49:55 -04:00

hylics2

Core: Remove Universally Unique ID Requirements (Per-Game Data Packages) (#1933)

2024-06-01 06:07:13 -05:00

inscryption

Inscryption: Implement new game (#3621)

2024-12-21 23:12:35 +01:00

kdl3

KDL3: Fix world access on non-strict open world (#4543)

2025-01-27 01:52:02 +01:00

kh1

Core/Various Worlds: Fix crash/freeze with unicode characters (#4671)

2025-03-14 08:24:37 +01:00

kh2

Core: update cx-Freeze to 8.0.0 & Worlds: fix packages missing __init__.py (#4773)

2025-04-01 16:29:32 +02:00

ladx

Core: update cx-Freeze to 8.0.0 & Worlds: fix packages missing __init__.py (#4773)

2025-04-01 16:29:32 +02:00

landstalker

Core: update cx-Freeze to 8.0.0 & Worlds: fix packages missing __init__.py (#4773)

2025-04-01 16:29:32 +02:00

lingo

Lingo: Add painting display names (#4707)

2025-03-27 01:32:39 +01:00

lufia2ac

Core/Docs: Adding apostrophe quotes around variables in printed error messages (#3914)

2024-12-19 20:47:33 -05:00

meritous

meritous: move completion_condition to set_rules (#4567)

2025-01-29 02:03:37 +01:00

messenger

The Messenger: Add display names to the plando options (#4748)

2025-03-19 15:52:14 -04:00

minecraft

Core: ensure requirements files end on newline (#4761)

2025-03-24 22:26:30 +01:00

mlss

MLSS: Fix issue with door opening earlier than intended (#4737)

2025-04-01 18:10:51 +02:00

mm2

MM2: Fix Shuffled Weaknesses Seed Bleed (#4689)

2025-02-27 11:13:37 -05:00

mmbn3

Core: update cx-Freeze to 8.0.0 & Worlds: fix packages missing __init__.py (#4773)

2025-04-01 16:29:32 +02:00

musedash

Muse Dash: Update Song List to Muse Dash Legend. (#4775)

2025-04-01 18:08:09 +02:00

noita

Noita: Fix bug with Traps disabled in 1-player games #4651

2025-02-23 17:27:05 +01:00

oot

WebHost: Standardize some 404 redirects (#4642)

2025-04-04 23:11:45 +02:00

osrs

Core: update cx-Freeze to 8.0.0 & Worlds: fix packages missing __init__.py (#4773)

2025-04-01 16:29:32 +02:00

overcooked2

oc2: Reduce calls to meets_requirements (#4060)

2024-10-29 11:07:49 +01:00

pokemon_emerald

Pokemon Emerald: Move recent change to new version (#4793)

2025-04-02 00:50:39 +02:00

pokemon_rb

Pokemon Red/Blue: Set allow_partial_entrances to true when building a state for ER #4802

2025-04-04 10:48:47 +02:00

raft

Raft: Place locked items in create_items and fix get_pre_fill_items (#4250)

2024-12-09 01:57:34 +01:00

rogue_legacy

Rogue Legacy: Remove item/location id overlap rejection code. (#3893)

2024-11-05 08:33:41 +00:00

ror2

RoR2: Remove recursion from explore mode access rules (#3681)

2024-08-07 23:57:07 +02:00

sa2b

SA2B: Fix critical typo #4779

2025-03-30 22:19:24 +02:00

saving_princess

Saving Princess: implement new game (#3238)

2024-12-07 11:29:27 +01:00

sc2

WebHost: Standardize some 404 redirects (#4642)

2025-04-04 23:11:45 +02:00

shivers

Shivers: Update shivers links and guides (#4592)

2025-02-07 21:06:06 +01:00

shorthike

A Short Hike: Fix Boat Rental purchase being incorrectly calculated (#3639)

2024-07-22 01:47:46 +02:00

sm

Super Metroid: Replace random module with world random in variaRandomizer (#4429)

2025-04-01 18:14:47 +02:00

sm64ex

Super Mario 64: ItemData class and tables (#4321)

2025-03-08 12:07:50 -05:00

smw

Core: update cx-Freeze to 8.0.0 & Worlds: fix packages missing __init__.py (#4773)

2025-04-01 16:29:32 +02:00

smz3

SMZ3: Change locality options earlier (#4424)

2025-01-19 23:07:01 -05:00

soe

SoE: update to v050 (#4497)

2025-01-17 18:53:29 +01:00

spire

Spire: Convert options, clean up random calls, and add DeathLink (#3704)

2024-07-31 18:27:35 +02:00

stardew_valley

Stardew: Fix minor grammar issues in Options (#4800)

2025-04-05 08:20:51 -04:00

subnautica

Subnautica: fix typo and remove no longer used logger (#4456)

2025-01-10 23:28:38 +01:00

terraria

Core: Remove Universally Unique ID Requirements (Per-Game Data Packages) (#1933)

2024-06-01 06:07:13 -05:00

timespinner

Timespinner: Support new flags and settings from the randomizer (#4559)

2025-03-08 11:54:23 -05:00

tloz

Core: ensure requirements files end on newline (#4761)

2025-03-24 22:26:30 +01:00

tunic

TUNIC: Error message in the spot that UT errors at if you have an old APWorld #4788

2025-04-05 00:53:13 +02:00

tww

Core: update cx-Freeze to 8.0.0 & Worlds: fix packages missing __init__.py (#4773)

2025-04-01 16:29:32 +02:00

undertale

Undertale: Fix slot_data and options.as_dict() (#3774)

2024-08-12 01:53:40 +02:00

v6

VVVVVV: Make unnecessary Trinkets filler (#3806)

2024-08-18 23:03:57 +02:00

wargroove

Wargroove: Switched to options API. (#3306)

2024-05-16 18:46:13 +02:00

witness

The Witness: Move the Easter Egg Hunt option group lower so that the tooltip isn't cut off (#4789)

2025-04-05 17:48:18 +02:00

yachtdice

Yacht Dice: Textual fixes and changes (Docs / yaml description) (#3967)

2024-10-28 02:37:21 +01:00

yoshisisland

Yoshi's Island: Fix Piece of Luigi not goaling until reset (#4709)

2025-04-05 16:07:37 +02:00

yugioh06

YGO06: add Item groups (#3737)

2024-12-01 04:09:22 +01:00

zillion

Core/Various Worlds: Fix crash/freeze with unicode characters (#4671)

2025-03-14 08:24:37 +01:00

zork_grand_inquisitor

Core: ensure requirements files end on newline (#4761)

2025-03-24 22:26:30 +01:00

__init__.py

Core: purge py3.8 and py3.9 (#3973)

2024-11-27 03:28:00 +01:00

AutoSNIClient.py

SNIClient: Let clients based on SNIClient monitor packages via on_package method (#3093)

2025-01-07 00:10:23 +01:00

AutoWorld.py

Core: Prevent worlds from using LogicMixin incorrectly (having class variables without an init_mixin) (#3974)

2025-04-05 18:06:30 +02:00

Files.py

APProcedurePatch: fix RLE/COPY incorrect sizing (#3006)

2024-03-22 09:02:38 +01:00

LauncherComponents.py

Launcher: Remove an unnecessary global (#4785)

2025-04-01 21:28:59 +02:00